[PM-14245] Remove policy definitions feature flag #5095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaunchDarkly flag references❌ 1 flag removed
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5095 +/- ##
==========================================
- Coverage 43.16% 43.14% -0.02%
==========================================
Files 1424 1424
Lines 65110 64919 -191
Branches 5968 5936 -32
==========================================
- Hits 28102 28010 -92
+ Misses 35755 35666 -89
+ Partials 1253 1243 -10 ☔ View full report in Codecov by Sentry. |
|
Fixed Issues
|
…-13322-add-policy-definitions-from-codebase
Patrick-Pimentel-Bitwarden
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Reviewed but asked for a second set of eyes because I'm new and there were moderate removals to the PolicyService @JaredSnider-Bitwarden should be taking a look as well.
JaredSnider-Bitwarden
approved these changes
Dec 2, 2024
…itions-from-codebase
BTreston
approved these changes
Dec 3, 2024
…itions-from-codebase
eliykat
deleted the
ac/pm-14245/remove-pm-13322-add-policy-definitions-from-codebase
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-14245
📔 Objective
Remove the
Pm13322AddPolicyDefinitionsfeature flag.PolicyService.SaveAsyncand private methods 🥳Auth: the changes to your code is just to use the new interface.
Client PR: bitwarden/clients#12172
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes